Re: [libvirt] [PATCH] build: silence false positive clang report

On 02/14/2011 04:37 PM, Eric Blake wrote: > clang complained that STREQ(group->controllers[i].mountPoint,...) was > a NULL dereference when i==VIR_CGROUP_CONTROLLER_CPUSET, because it > assumes the worst about virCgroupPathOfController. Marking the > argument const doesn't yet have an effect, per this clang bug: > http://llvm.org/bugs/show_bug.cgi?id=7758 > > So, we use sa_assert, which was designed to shut up false positives > from tools like clang. > > * src/util/cgroup.c (virCgroupMakeGroup): Teach clang that there > is no NULL dereference.

> + /* As of Feb 2011, clang can't see that the above function > + * call did not modify group. */ > + sa_assert(group->controllers[i].mountPoint); > ACK.