Re: [libvirt] [PATCH] libxl: advertise support for migration V3
On 08/29/2016 06:20 PM, Jim Fehlig wrote:
The libxl driver has long supported migration V3 but has never
indicated so in the connectSupportsFeature API.
Hmm, but IIRC it was only since "recent" commit 8db77b3 right? Or rather
Nikolay's
reworking top-level migration code, which effectively would convert to the params
versions accordingly. Before that rework I think one had to implement both params and
non-params variants. Would it be worth adding a comment mainly to help the reader?
(I vaguely remember this as I dropped my v3 patch as being no longer necessary)
As a result, apps
such as virt-manager that use the more generic virDomainMigrate API
fail with
libvirtError: this function is not supported by the connection driver:
virDomainMigrate
Add VIR_DRV_FEATURE_MIGRATION_V3 to the list of features marked as
supported in the connectSupportsFeature API.
FWIW and irrespective of the comment above:
Reviewed-by: Joao Martins <joao.m.martins(a)oracle.com>