Re: [Libvir] Re: PATCH 1/2: Qemu feature reporting
David Lutterkort wrote:
This patch lets the qemu/kvm drivers report features for i686 and
x86_64. The output is table-driven, like the rest of the capability
generation. That should make it easy to report additional features for
other arches (which I know zip about)
This patch is fine, except I'd recommend using the STREQ/STRNEQ macros
(defined in src/internal.h) instead of:
+ if (strcmp(flags[i].name, "pae") == 0) {
But it's not a big problem.
Rich.
--
Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in
England and Wales under Company Registration No. 03798903
Attachments:
- smime.p7s (application/x-pkcs7-signature — 3.2 KB)