Re: [libvirt] [PATCH 4/4] qemu: Fix qemuProcessInitCpuAffinity()

On 5/31/19 11:22 AM, Andrea Bolognani wrote: > @@ -2489,11 +2489,16 @@ qemuProcessInitCpuAffinity(virDomainObjPtr vm) > if (virDomainNumaGetNodeCount(vm->def->numa) <= 1 && > virDomainNumatuneGetMode(vm->def->numa, -1, &mem_mode) == 0 && > mem_mode == VIR_DOMAIN_NUMATUNE_MEM_STRICT) { > + virBitmapPtr nodeset = NULL; > + > if (virDomainNumatuneMaybeGetNodeset(vm->def->numa, > priv->autoNodeset, > - &cpumapToSet, > + &nodeset, > -1) < 0) > goto cleanup; > + > + if (virNumaNodesetToCPUset(nodeset, &cpumapToSet) < 0) > + goto cleanup; Coverity complained this morning because virNumaNodesetToCPUset will allocate something into @cpumapToSet which isn't free'd when this code jumps to cleanup.