Re: [PATCH v2 26/27] virsh: Introduce --virtio to setmem
On Thu, Dec 03, 2020 at 13:36:29 +0100, Michal Privoznik wrote:
Provide an user friendly way of modifying 'requested-size' of
a
virtio-mem device. New --node and --alias arguments are
introduced but they are needed only if it is not clear which
virtio-mem does user mean.
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
---
docs/manpages/virsh.rst | 6 ++
tools/virsh-domain.c | 126 ++++++++++++++++++++++++++++++++++++----
2 files changed, 122 insertions(+), 10 deletions(-)
NACK to overloading 'setmem'. You have two almost completely distinct
code paths with a completely new set of arguments. You can directly add
a new command instead.