Re: [libvirt] [PATCH] fix memory leak in virCopyLastError

On Fri, Sep 14, 2012 at 02:24:15PM +0800, Hu Tao wrote:

memset before virResetError will cause memory leak.

virResetError and virCopyError, which calls virResetError, will do memset properly, so we don't have to worry about it here.

Disagree, it's a public API, we can't justify behaviour just on how it is used internally. NACK, at least the explanation need to be fixed What is the scenario for the leak ? Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/