[libvirt] [PATCH] util: Fix resource leak
The virRotatingFileWriterAppend method leaks the file->entry
on the virRotatingFileWriterEntryNew failing path.
---
src/util/virrotatingfile.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/src/util/virrotatingfile.c b/src/util/virrotatingfile.c
index 9144729..83a695f 100644
--- a/src/util/virrotatingfile.c
+++ b/src/util/virrotatingfile.c
@@ -483,18 +483,19 @@ virRotatingFileWriterAppend(virRotatingFileWriterPtr file,
if ((file->entry->pos == file->maxlen && len) ||
forceRollover) {
- virRotatingFileWriterEntryPtr tmp = file->entry;
+ virRotatingFileWriterEntryPtr tmp;
VIR_DEBUG("Hit max size %zu on %s (force=%d)\n",
file->maxlen, file->basepath, forceRollover);
if (virRotatingFileWriterRollover(file) < 0)
return -1;
- if (!(file->entry = virRotatingFileWriterEntryNew(file->basepath,
- file->mode)))
+ if (!(tmp = virRotatingFileWriterEntryNew(file->basepath,
+ file->mode)))
return -1;
- virRotatingFileWriterEntryFree(tmp);
+ virRotatingFileWriterEntryFree(file->entry);
+ file->entry = tmp;
}
}
--
2.8.3