Re: [PATCH 1/5] libvirt_private.syms: Export virNetlinkBridgeVlanFilterSet

On Mon, May 12, 2025 at 15:37:12 +0200, Michal Privoznik via Devel wrote: > From: Michal Privoznik <mprivozn(a)redhat.com&gt; > > The function was introduced in v11.0.0-rc1~23 but corresponding > change to the private syms file was missing. > > Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com&gt; > --- > src/libvirt_private.syms | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms > index a8ebf9efd8..727b4b2caa 100644 > --- a/src/libvirt_private.syms > +++ b/src/libvirt_private.syms > @@ -3037,6 +3037,7 @@ virNetDevVPortProfileOpTypeToString; > > > # util/virnetlink.h > +virNetlinkBridgeVlanFilterSet; > virNetlinkCommand; > virNetlinkDelLink; > virNetlinkDumpCommand; Hmm seems that it was used only from src/util/virnetdevbridge.c thus the linker didn't need it outside. I presume you want to mock or use it; please mention that in the commit message because the justification there doens't make sense unless you want to use it outside of src/util/