Re: [libvirt] [PATCH 6/6] qemu: monitor: Properly configure backend for UDP chardevs
On Wed, Oct 05, 2016 at 09:39:06 -0400, John Ferlan wrote:
On 09/27/2016 12:39 PM, Peter Krempa wrote:
> Since introduction of chardev hotplug the code was wrong for the UDP
> case and basically created a TCP socket instead. Use proper objects and
> type for UDP.
>
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1377602
> ---
> src/qemu/qemu_monitor_json.c | 12 ++++++++++--
> tests/qemumonitorjsontest.c | 20 ++++++++++++++++----
> 2 files changed, 26 insertions(+), 6 deletions(-)
>
As I read the bug, the code below, and the qemu_command code - it seems
the bug describes issues with both qemu_command and the hotplug code.
The command line portion actually is not wrong. It generates the
address pair with type UDP as it should. The reporter of that bugzilla
has just improper expectations of UDP socket capabilities.
Also it's very unlikely that somebody is actually using the qemu UDP
backend. It was broken for rather long time up until last year.
Peter
Attachments:
- signature.asc (application/pgp-signature — 801 bytes)