Re: [libvirt PATCH v2 1/7] util: Unify virSystemdHas{Machined,Logind}
On Mon, Feb 05, 2024 at 03:14:08PM +0100, Jiri Denemark wrote:
When checking for machined we do not really care whether systemd
itself
is running, we just need machined to be either running or socket
activated by systemd. That is, exactly the same we do for logind.
That's not right. We very much *do* care whether systemd is
running.
If systemd-machined is installed on the host but the OS is
booted into sysvinit, then DBus will report that machined
can be activated, but if it is activated then it certainly
won't actually work.
Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com>
---
src/util/virsystemd.c | 74 ++++++++++++++++++++-----------------------
1 file changed, 34 insertions(+), 40 deletions(-)
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|