Re: [libvirt] [PATCH v3 11/12] docs: Add 'uid' and 'fid' information
On Tue, 2018-08-07 at 17:10 +0800, Yi Min Zhao wrote:
[...]
+ have multiple functions used. (<span
class="since">Since 4.7.0
+ </span>), PCI address extensions depending on the architecture
+ are supported. E.g. for S390 guests, PCI addresses have
+ additional attributes: <code>uid</code> (a hex value between
+ 0x1 and 0xffff, inclusive), and <code>fid</code> (a hex value
+ between 0x0 and 0xffffffff, inclusive), which are used by PCI
+ devices on S390 for User-defined Identifiers and Function
+ Identifiers.<br/>
I would format the minimum values for uid and fid as 0x0001 and
0x00000000 respectively for consistency - that's how they will
show up in the domain XML after all.
Reviewed-by: Andrea Bolognani <abologna(a)redhat.com>
--
Andrea Bolognani / Red Hat / Virtualization