Re: [libvirt] [PATCH 2/3] tests: Only use privileged mode if Qemu user and group exists
On 04/08/2014 07:06 AM, Guido Günther wrote:
>> What about passing 'false' to ConfigNew() but then
manually
>> set 'cfg->privileged = true' on the object we get back.
>>
>
> That could work. All tests passed on my setup like that. And it
> doesn't seem weird since we're playing with the config a lot in the
> tests.
I do wonder if my approach wouldn't be cleaner since it doesn't poke
into the objects internals.
Your approach skips the test, which means less testsuite coverage. I'd
rather poke into internals to make the testsuite independent of the
environment while still maximizing coverage.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 604 bytes)