Re: [libvirt] [PATCHv2 08/33] storage: Add storage file API to read file headers

On 05/22/2014 07:47 AM, Peter Krempa wrote: > Add storage driver based functions to access headers of storage files > for metadata extraction. Along with this patch a local filesystem and > gluster via libgfapi implementation is provided. The gluster > implementation is based on code of the saferead_lim function. > --- > src/storage/storage_backend.h | 7 ++++ > src/storage/storage_backend_fs.c | 30 ++++++++++++++++ > src/storage/storage_backend_gluster.c | 66 +++++++++++++++++++++++++++++++++++ > src/storage/storage_driver.c | 40 +++++++++++++++++++++ > src/storage/storage_driver.h | 3 ++ > 5 files changed, 146 insertions(+) >

ACK if you agree about the return value fix, and if it is the only change you make besides the typo fix.