On Mon, Jan 30, 2012 at 16:13:37 -0700, Eric Blake wrote:
On 01/30/2012 09:01 AM, Jiri Denemark wrote:
--- src/qemu/qemu_conf.h | 1 + src/qemu/qemu_driver.c | 83 ++++++++++++++++++++++++++++++++++++++++++ src/qemu/qemu_monitor.c | 40 ++++++++++++++++++++ src/qemu/qemu_monitor.h | 1 + src/qemu/qemu_monitor_json.c | 8 ++++ src/qemu/qemu_monitor_text.c | 15 ++++++++ 6 files changed, 148 insertions(+), 0 deletions(-)
...
+++ b/src/qemu/qemu_monitor_text.c @@ -839,6 +839,21 @@ int qemuMonitorTextGetBlockInfo(qemuMonitorPtr mon, VIR_DEBUG("error reading tray_open: %s", p);
Do we still need to implement this in qemu_monitor_text, now that we require JSON for any qemu version new enough to actually provide this information in the first place?
I guess we don't but v1 predates your patch and I tested the code worked so I just didn't remove it :-) Jirka