Re: [PATCH 2/2] nbd/server: Allow users to adjust handshake limit in QMP
On Thu, Feb 06, 2025 at 10:20:09AM +0300, Vladimir Sementsov-Ogievskiy wrote:
> ---
> qapi/block-export.json | 10 ++++++++++
> include/block/nbd.h | 6 +++---
[..]
> @@ -52,6 +57,10 @@
> #
> # @addr: Address on which to listen.
> #
> +# @handshake-max-secs: Time limit, in seconds, at which a client that
> +# has not completed the negotiation handshake will be disconnected,
> +# or 0 for no limit (since 10.0; default: 10).
> +#
Hmm. [not about the series], shouldn't we finally deprecate older interface?
By older interface, you are asking about the QMP command
'nbd-server-start' as compared to struct NbdServerOptions. But the
struct is not directly present in any QMP commands; rather, it only
appears to be used by qemu-storage-daemon as one of its command line
options that needs to set up an NBD server with a JSON-like syntax
that has less nesting than QMP nbd-server-start. blockdev-nbd.c has
two functions [nbd_server_start_options(NbdServerOPtions *arg...) and
qmp_nbd_server_start(args...)] that both unpack their slightly
different forms and pass them as parameters to nbd_server_start() that
is then agnostic to whether the older QMP command or newer q-s-d CLI
option was specified.
It looks like libvirt is still using QMP nbd-server-start. If we were
to start the deprecation process for qemu 10.0, what would the new
command look like? What would everyone be required to use by qemu
10.2?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org