Re: [libvirt] [PATCH] tests: Add fchostdata in EXTRA_DIST
On 15/05/13 04:50, Eric Blake wrote:
On 05/14/2013 11:41 AM, Osier Yang wrote:
> Pushed under build-breaker rule.
> ---
> tests/Makefile.am | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/Makefile.am b/tests/Makefile.am
> index f53e208..2822d39 100644
> --- a/tests/Makefile.am
> +++ b/tests/Makefile.am
> @@ -86,7 +86,8 @@ EXTRA_DIST = \
> xmconfigdata \
> xml2sexprdata \
> xml2vmxdata \
> - .valgrind.supp
> + .valgrind.supp \
> + fchostdata
Any reason you didn't keep the list sorted?
I pushed one fix for the sorting:
commit 5606c7a8674286b20834760a6f2209659c343809
Author: Osier Yang <jyang(a)redhat.com>
Date: Wed May 15 11:34:27 2013 +0800
tests: Sort the EXTRA_DIST list
Commit 1cc8259bfe17 fixes the build failure, but forgot to keep the
list alphanumeric sorted.
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 2822d39..41c4067 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -52,6 +52,7 @@ EXTRA_DIST = \
domainsnapshotschematest \
domainsnapshotxml2xmlin \
domainsnapshotxml2xmlout \
+ fchostdata \
interfaceschemadata \
lxcxml2xmldata \
networkschematest \
@@ -86,8 +87,7 @@ EXTRA_DIST = \
xmconfigdata \
xml2sexprdata \
xml2vmxdata \
- .valgrind.supp \
- fchostdata
+ .valgrind.supp