Re: [libvirt] [PATCH 1/5] NEWS: Move generation to the docs/ directory
On Wed, 2018-03-14 at 09:56 +0000, Daniel P. Berrangé wrote:
On Tue, Mar 13, 2018 at 07:42:43PM +0100, Andrea Bolognani wrote:
> All the input files and scripts used to generate the release notes
> live in the docs/ directory, so it makes sense for the output file
> to be created there as well. A symbolic link is created in the
> top-level source directory to comply with GNU standards as well as
> user expectations.
I'm not really seeing a benefit in having a NEWS file in both
places.
You're only going to get a single copy plus a symlink. Well, for
git checkouts at least: 'make dist' will dereference all symlinks,
so the release tarballs will indeed include the file twice. That's
a more general issue with 'make dist' that it would be nice to
find a solution for. IIRC Michal brought it up with the autotools
maintainers a while ago, but nothing came of it.
What's the problem you're trying to solve with having
it in the top directory ?
The rules for generating NEWS are in the top-level Makefile.am,
but all the files involved in the process are actually in docs/.
I think it would be nicer to move the rules to docs/Makefile.am
so that they live alongside the files and docs/ is more
self-contained, but I can live with the current state if you're
against this change.
--
Andrea Bolognani / Red Hat / Virtualization