On 02/05/2014 03:09 PM, Cédric Bosdonnat wrote:
Here is an updated version of the patch set fixing comments from
Daniel.
It also adds 3 commits:
* One adding conversion for the newly supported blkio throttle tune
in lxc driver.
* One actually using the state of the veth network device in lxc
driver.
* One adding the ability to give major:minor numbers instead of a path
for blkio tune devices.
The last one is a way to address Daniel's comment on the /dev/block/...
paths.
Cédric Bosdonnat (21):
Improve virConf parse to handle LXC config format
LXC driver: started implementing connectDomainXMLFromNative
LXC from native: import rootfs
LXC from native: migrate fstab and lxc.mount.entry
LXC from native: implement no network conversion
LXC from native: migrate veth network configuration
LXC from native: convert phys network types to net hostdev devices
LXC from native: convert lxc.tty to console devices
LXC from native: convert macvlan network configuration
LXC from native: convert lxc.id_map into <idmap>
LXC from native: migrate memory tuning
LXC from native: map lxc.cgroup.cpu.*
LXC from native: map lxc.cgroup.cpuset.*
LXC from native: add lxc.cgroup.blkio.* mapping
LXC from native: map lxc.arch to /domain/os/type@arch
LXC from native: map block filesystems
LXC from native: map vlan network type
LXC: added some doc on domxml-from-native with mention of limitations
LXC from native: convert blkio throttle config
lxc: honor link state=up for veth interfaces
blkiotune: allow <node major='' minor=''/> in place of
<path>
...
src/lxc/lxc_native.c | 952
+++++++++++++++++++++
Hi,
The use of 'link' as a function parameter breaks the build on RHEL-6.4:
cc1: warnings being treated as errors
../../src/lxc/lxc_native.c: In function 'lxcCreateNetDef':
../../src/lxc/lxc_native.c:337: error: declaration of 'link' shadows a global
declaration [-Wshadow]
/usr/include/unistd.h:809: error: shadowed declaration is here [-Wshadow]
../../src/lxc/lxc_native.c: In function 'lxcAddNetworkDefinition':
../../src/lxc/lxc_native.c:414: error: declaration of 'link' shadows a global
declaration [-Wshadow]
/usr/include/unistd.h:809: error: shadowed declaration is here [-Wshadow]
make[3]: *** [lxc/libvirt_driver_lxc_impl_la-lxc_native.lo] Error 1
Jan