Re: [Libvir] [PATCH] setmem checks
On Thu, Jun 14, 2007 at 04:45:49PM -0400, Mark Johnson wrote:
This one may be a little contentious...
This patch does a couple of things... It won't let you
set memory if the value is greater that maxmem.
It also will lower memory if max memory is set
to less than memory.
Yeah, that's a fairly reasonable argument to make, otherwise you're just
pushing the burden onto the admin to call virsh dominfo everytime first.
I think it's a good argument that this checking
should be in the hypervisor control daemon.
IMO, it should be both here and in the daemon.
Surprised the Xen Hypervisor doesn't already apply this logic
itself actually.
Dan.
--
|=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=|
|=- Perl modules: http://search.cpan.org/~danberr/ -=|
|=- Projects: http://freshmeat.net/~danielpb/ -=|
|=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|