Re: [libvirt PATCH 07/11] virnetclient: Use 'if' consistently

On Mon, Feb 14, 2022 at 08:09:57AM -0800, Andrea Bolognani wrote: > > > Can you please provide pointers to the OpenStack implementation of > > > this and the issue that resulted from introducing virt-ssh-helper? > > > > I don't know where the code is. I just know that they were broken > > by our changes in this area. > > I have found some of the issues filed at the time > > https://bugs.launchpad.net/tripleo/+bug/1918250 > https://bugzilla.redhat.com/show_bug.cgi?id=1936804 > > and the corresponding fix > > https://github.com/rdo-packages/nova-distgit/commit/d5aba75f3b5589e156afe... > > The detection logic, as currently implemented, is a bit fragile, but > updating it so that it keeps working even as we make minor > adjustments to our ssh tunnel script wasn't particularly difficult > > https://github.com/andreabolognani/nova-distgit/commit/27cee8da127c1d447c... It isn't about whether it is difficult or not though. It is showing that the changes in libvirt are creating a compatibility problem for existing application code, and that any changes we make here will require further changes in such applications. I've not been explicit about back compatibility in this area, as we didn't realize apps would be sensitive to changes. Now we know that, I don't think we should be knowingly making further changes that are likely to break apps.