On Mon, 2021-02-15 at 11:10 +0100, Peter Krempa wrote:
On Mon, Feb 15, 2021 at 10:59:47 +0100, Andrea Bolognani wrote:
After the recent fixes, it's now confirmed to work.
Should it be closed then?
I will close it as soon as this is pushed :)
+* **Portability** + + * Implement Apple Silicon support
Just semantics, wasn't the problem just in the test suite? In which case I'd consider it more of a fix than implementation.
Most of the changes indeed happened in the test suite, but some tweaks to the aarch64 CPU driver were necessary as well, specifically: https://gitlab.com/libvirt/libvirt/-/commit/82ffb81c9cafbcdf7b1f56f9644883fe... https://gitlab.com/libvirt/libvirt/-/commit/03af15c0242fdb485fc639f24b9acef9... https://gitlab.com/libvirt/libvirt/-/commit/f834c341fbec94ead3671931c58db9c0... As for whether this should be considered a bug fix, of course the line between the various release notes sections is not entirely well defined and there's always some overlap / leeway... I would consider this a bug fix if we had Apple Silicon support in the past and broke it, but since the hardware literally didn't exist until a few months ago, I think it qualifies as a new feature - it just so happens to be one where we could piggy-back on existing features almost completely ;)
Regardless of the above,
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
Thanks! Pushed now. -- Andrea Bolognani / Red Hat / Virtualization