Re: [libvirt] [dbus PATCH] connect: fix g_free order in virtDBusConnectFree
On 07/03/2018 09:03 AM, Ján Tomko wrote:
On Tue, Jul 03, 2018 at 02:18:02PM +0200, Pavel Hrdina wrote:
> On Mon, Jul 02, 2018 at 11:42:08AM -0400, Anya Harter wrote:
>> so that g_free(connect->nodeDevPath) line appears in alphabetical order
>> with the rest of the lines
>>
>> Signed-off-by: Anya Harter <aharter(a)redhat.com>
>> ---
>> src/connect.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> In general we don't send/merge patches that just move code without any
> functional reason because it pollutes git history but in this case I
> would say it's ok.
>
What about the gchar *nodeDevPath; declaration in connect.h?
It is also in a different order.
This is a good catch.
How would you do something that isn't functional as part of a different
commit? Wouldn't it confuse someone looking at it?
Thanks,
Anya
/me runs
Jano
> Reviewed-by: Pavel Hrdina <phrdina(a)redhat.com> and pushed.
> --
> libvir-list mailing list
> libvir-list(a)redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list