Re: [libvirt] PATCH: Fix many many win32 bugs
On Wed, Jul 22, 2009 at 09:09:25PM +0100, Daniel P. Berrange wrote:
Latest GCC changed the meaning of 'printf' attribute
annotation to refer
to the host platform's native format specifiers. On Win32/mingw32 this
means it is now validating against Microsoft's useless format specifiers.
We replace all the printf like functions on Win32 thanks to GNULIB and
thus should always validate against the GNU format specifiers.
This means we have to use the 'gnu_printf' annotation everywhere, but
only for GCC >= 4.4.
This also disables the 'pwd' and 'cd' commands in virsh because neither
of those build successfully on Win32.
Finally, disables the OpenNebula driver on Win32
Looks fine to me, the main change still being the new
ATTRIBUTE_FMT_PRINTF
ACK,
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/