Re: [libvirt] [PATCH] qemu_hotplug: correctly parse device XML provided by user
On Sat, May 14, 2016 at 07:27:36PM +0200, Pavel Hrdina wrote:
Commit 1ccc7fbf fixed port checking for live device update, which
revealed another bug. If we updating live domain we need to parse the
device also as live.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1336134
Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com>
---
NACK, this isn't correct fix. The issue here is that we drop ports if autoport
is set and flag VIR_DOMAIN_DEF_PARSE_INACTIVE is set. To fix this issue we have
to revert 1ccc7fbf where I didn't realize this fact.