Re: [PATCH] esx: Avoid corner case where esxUtil_ParseDatastorePath could be called with NULL 'datastorePath'

On Mon, Jun 02, 2025 at 11:03:26AM +0200, Peter Krempa via Devel wrote:

From: Peter Krempa <pkrempa@redhat.com>

The generated code which parses the data from XML in esxVI_LookupDatastoreContentByDatastoreName can fill the 'folderPath' property with NULL if it were missing from the input XML. While this is not likely when talking to esx it is a possible outcome. Skipp NULL

s/Skipp/Skip/

results.

All other code paths already ensure that the function is not called with NULL.

Closes: https://gitlab.com/libvirt/libvirt/-/issues/776 Signed-off-by: Peter Krempa <pkrempa@redhat.com> --- src/esx/esx_storage_backend_vmfs.c | 6 ++++++ 1 file changed, 6 insertions(+)

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>