Re: [PATCH 07/22] qemu: Reject 'preserve' action for 'on_reboot'/'on_poweroff'/'on_crash'
On 15.09.21 11:45, Christian Borntraeger wrote:
On 24.08.21 16:44, Peter Krempa wrote:
> The qemu driver didn't ever implement any meaningful handling for the
> 'preserve' action.
>
> Forbid the flag in the qemu def validator and update the documentation
> to be factual.
>
> Signed-off-by: Peter Krempa <pkrempa(a)redhat.com>
NACK. It is a perfectly sane usecase to have "preserve" on a crash. The qemu
will simply sit in that state and the user can then do virsh dump or similar.
To make this statement stronger. I use this A LOT in real life to force libvirt
to leave the QEMU in that state to get dump and debug info.