On 04/04/2012 08:07 AM, Daniel P. Berrange wrote:
From: "Daniel P. Berrange" <berrange@redhat.com>
---
Sparse on the commit message; even mentioning the name of the new API will help a later 'git log' search for the introduction of the new name.
daemon/libvirtd-config.c | 67 +++++++++++++++++++++++++++++++-------------- daemon/libvirtd-config.h | 9 ++++-- daemon/libvirtd.c | 2 +- 3 files changed, 53 insertions(+), 25 deletions(-)
- - conf = virConfReadFile (filename, 0);
Bad style (space in function call) here...
- virConfFree (conf); return 0;
error: - virConfFree (conf);
and here...
+ + conf = virConfReadFile(filename, 0);
but while you fixed it here...
+ if (!conf) + return -1; + + ret = daemonConfigLoadOptions(data, filename, conf); + virConfFree (conf);
...you missed here. ACK with that nit fixed. -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org