Re: [libvirt] [PATCH] phyp: fix logic error on volume creation
On 02.04.2014 01:39, Eric Blake wrote:
The phyp code claims that it wants a non-zero value, but actually
enforces a capacity of zero. It has been this way since commit
ebc46fe in June 2010. Bummer that it has my name as the committer
- I guess I should have been much more stubborn about not blindly
taking someone else's 1600-line patch.
* src/phyp/phyp_driver.c (phypStorageVolCreateXML): Use correct
logic.
Signed-off-by: Eric Blake <eblake(a)redhat.com>
---
The fact that this bug has gone unnoticed for years makes me
wonder if we are better off just removing the phyp driver from
our code base, since it is obvious it is not getting much
testing. I'm also waiting for a review on this, because although
I _think_ the code wanted a non-zero capacity, I don't know
enough about phyp and the "viosvrcmd -c 'mklv -lv'" command line;
maybe the comments are wrong and it always wanted 0 capacity
instead (which is the only thing that would get past the
pre-patch code check).
C'mon. Who's really creating volumes via libvirt? I mean, the fact that
users don't create volumes via libvirt doesn't mean they are not using
phyp driver. I probably should not say this aloud, but I used volume
creation only when starting with libvirt. I used to play with
virt-manager to get sense of libvirt's capabilities. I admit that things
are different now sice we have domains and storage pools tied together,
but not for me as I'm already used to doing it the other way.
Michal