Re: [libvirt] [PATCH] virsh: add new vol-pool command

On 06/08/2010 08:06 AM, Justin Clift wrote: When resending, it helps to use 'git send-email --subject-prefix=PATCHv2' to call attention to the fact that it is a resend. Also, if you list what changed between v1 and v2, it makes subsequent reviews easier for anyone who read the first version. Listing it after the --- output by git means that it is not part of the git commit message but is part of the email (here, I use git send-email --annotate to pull up an editor on everything I'm about to send, and type after the ---); but several others on this list find it easier to track their v2, v3, ... changes directly in the commit message. I kind of like the sideband effect of doing it only in the email (a year from now, when reading 'git log', I don't care how many tries it took you to get to what was actually committed, if the intermediate tries weren't also committed), but tracking the changes with 'git commit --amend' is also nice, so a compromise is to keep your interdiff changelog in the commit messages locally, then manually move the --- up a few lines when doing the 'git send-email' so that someone else doing 'git am' doesn't replay the history. Given your separate email with the virsh.pod patches for this and several other vol-* commands at once, ACK. -- Eric Blake eblake(a)redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org