Re: [libvirt] [PATCH 5/8] conf: domain: add VIDEO_TYPE_DEFAULT
On 06/28/2017 02:49 PM, Cole Robinson wrote:
Will be needed for future patches to pull the default video type
setting out of XML parsing routines.
Signed-off-by: Cole Robinson <crobinso(a)redhat.com>
---
src/conf/domain_conf.c | 1 +
src/conf/domain_conf.h | 1 +
src/qemu/qemu_command.c | 3 +++
src/qemu/qemu_domain.c | 1 +
src/qemu/qemu_domain_address.c | 1 +
tests/domaincapsschemadata/full.xml | 1 +
6 files changed, 8 insertions(+)
Well, I see why you added patch 3 now... But I'm still convinced it's
better to have all switch/cases handle every case.
My only concern here would be related to migration, but since it doesn't
appear that "default" can be saved to the XML file I think we're good. I
will guarantee someone in qe will find this default and find some
oddball path that tries to allow it to be defined in some read XML file.
Reviewed-by: John Ferlan <jferlan(a)redhat.com>
John