26 Jul
2013
26 Jul
'13
2:14 p.m.
On 07/26/2013 01:18 PM, Daniel P. Berrange wrote:
On Fri, Jul 26, 2013 at 12:28:20PM +0200, Ján Tomko wrote:
Ján Tomko (4): Set the number of elements to 0 in virNetwork*Clear Don't check validity of missing attributes in DNS SRV XML Remove double space in error messages Remove redundant free in virNetworkDNSHostDefParseXML
src/conf/network_conf.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-)
IMHO you should be including one or more test data files to demonstrate the crash & fix.
That can't be done with just data files, a new test for network XML sections is needed. virNetworkDefUpdateSection seems like the right function to test. Jan