Re: [libvirt] [libvirt RFC PATCH 01/10] tests: Add testing of backing store string parser

On 07/15/2016 07:46 AM, Peter Krempa wrote:

As we already test that the extraction of the backing store string works well additional tests for the backing store string parser can be made simpler.

Export virStorageSourceNewFromBackingAbsolute and use it to parse the backing store strings, format them using virDomainDiskSourceFormat and match them against expected XMLs. --- src/libvirt_private.syms | 1 + src/util/virstoragefile.c | 2 +- src/util/virstoragefile.h | 3 ++ tests/virstoragetest.c | 78 +++++++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 83 insertions(+), 1 deletion(-)

ACK -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org