Re: [libvirt] [PATCH] virsh: Add a completer for `domifaddr` --source parameter.
On Thu, Jan 02, 2020 at 12:07:06PM -0300, Julio Faracco wrote:
The command `domifaddr` can use three different sources to grab IP
address of a Virtual Machine: lease, agent and arp. This parameter does
not have a completer function to return source options.
Signed-off-by: Julio Faracco <jcfaracco(a)gmail.com>
---
...
+
+char **
+virshDomainIfAddrSourceCompleter(vshControl *ctl,
I'd stay consistent with the existing naming scheme we have in place and expand
'If' to 'Interface' --> virshDomainInterfaceAddrSourceCompleter.
Changed and pushed.
Reviewed-by: Erik Skultety <eskultet(a)redhat.com>