Re: [libvirt] [snmp PATCH 09/20] src: Fix header file defines
On Thursday, 18 October 2018 14:26:47 CET Michal Privoznik wrote:
To avoid multiple includes, header files start with:
#ifndef __SOMETHING__
# define __SOMETHING__
Well, SOMETHING should be the file name, and there should be a
space after hash and before 'define'.
Note that identifier start that with two underscores (or even with two
underscores in their name, IIRC) are reserved for the system.
I know the likelyhood of a name conflict with a system identifier with
LIBVIRT in the name is very low, still I saw people reporting these
"reserved names used" issues in the past.
I'd simply use LIBVIRTSNMP_ (or something like that) as prefix.
--
Pino Toscano
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)