19 Aug
2010
19 Aug
'10
6:26 p.m.
On 08/19/2010 03:10 PM, Matthias Bolte wrote:
2010/8/19 Eric Blake <eblake@redhat.com>:
* src/storage/storage_backend.c (virStorageBackendCreateQemuImg) (virStorageBackendCreateQcowCreate): Use virAsprintf instead. * src/storage/storage_backend_disk.c (virStorageBackendDiskCreateVol, virStorageBackendDiskPartFormat): Likewise. ---
Things to look out for: virStorageBackendDiskPartFormat can now fail where it used to do nothing to the passed-in partFormat variable, if the switch statement hits the default.
Nice one, before it would just have executed parted with a random string in the argumentlist in that case.
ACK.
Thanks; pushed. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org