Re: [libvirt] [PATCH] Prefer to use 'qemu-system-i386' over 'qemu'
On 03/26/2012 09:59 AM, Daniel P. Berrange wrote:
From: "Daniel P. Berrange" <berrange(a)redhat.com>
For i686 arch we look for the 'qemu' binary, followed by the
'qemu-system-x86_64' binary. This is not good with QEMU 1.0,
since the 'qemu' binary was renamed to 'qemu-system-i386'
and the 'qemu' name might be reused for another purpose
later.
Make sure we look for 'qemu-system-i386', then 'qemu-system-x86_64'
then the qemu-kvm binary. Only use 'qemu' as a very last resort
Should we be favoring x86_64 first? As I understand it:
i686 host can use qemu-system-i386 (fast with kvm); I'm not sure if it
can use qemu-system-x86_64 (but if it does, it won't be with kvm, so it
will be slow)
x86_64 host can use either emulator, and both will be fast thanks to kvm.
I'm not necessarily opposed to your choice of ordering, but a bit more
rationale in the commit message might help.
At any rate,
ACK.
--
Eric Blake eblake(a)redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 620 bytes)