Re: [libvirt] [PATCH RFC 2/2] support configuring the format of dumping memory in qemu.conf
On Wed, Jan 29, 2014 at 10:15:36AM +0800, Qiao Nuohan wrote:
This patch is used to add dump_memory_format to qemu.conf and make
the
specified format as the default dump format of 'virsh dump --memory-only'.
But when "--compress" is specified with dump command, the format configured
by dump_memory_format will be overrided. dump_memory_format can one of elf,
kdump-zlib, kdump-lzo and kdump-snappy. And elf is the default value.
I think it is pretty horribly misleading to applications if they
leave out the VIR_DUMP_COMPRESS flag when invoking the API but
libvirt then asks for compression anyway. If an application is
only able to cope with uncompressed format then they are screwed
by the host level setting which they can't see.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|