Re: [libvirt] [PATCH for 5.3.0] news: Update for 5.3.0 release
On Tue, 2019-04-30 at 14:43 +0200, Michal Privoznik wrote:
[...]
+ <section title="Removed features">
+ <change>
+ <summary>
+ Drop support for VirtualBox 4.x releases
vbox: Drop support ...
[...]
+ <change>
+ <summary>
+ Drop yajl-1 support in favour of yajl-2
Just
Drop YAJL 1 support
will do: saying that we're dropping it in favour of YAJL 2 is not
really accurate anyway, since we have mantained support for both in
parallel for a very long time :)
+ </summary>
+ <description>
+ Yajl-2 is widely adapted and maintaining side by side
+ support for two versions is needless.
s/Yajl-2/YAJL 2/
s/adapted/adopted/
s/needless/unnecessary/
+ </description>
+ </change>
+ <change>
+ <summary>
+ tests: add targets for building libvirt inside Docker containers
+ </summary>
+ <description>
+ Strictly speaking this does not concern users, but it
+ is still worth mentioning. New build targets are
+ introduced to build and test libvirt under various
+ docker images, for instance make
+ <code>ci-build@fedora-28</code>
+ </description>
+ </change>
I disagree this is release notes material, but if you really want to
include it move 'make' inside the <code> element.
[...]
+ <change>
+ <summary>
+ qemu: Make hugepages work with memfd backend
+ </summary>
+ <description>
+ Due to a bug in command line generation libvirt did not
+ honoured hugepages setting with memfd backend.
... did not honor ...
With these few nits fixed,
Reviewed-by: Andrea Bolognani <abologna(a)redhat.com>
Thanks for taking care of this! I owe you a $BEVERAGE :)
--
Andrea Bolognani / Red Hat / Virtualization