Re: [libvirt] [PATCH 06/13] qemu: Generate and use zPCI device in QEMU command line

On Thu, May 24, 2018 at 02:24:31PM +0200, Xiao Feng Ren wrote: > From: Yi Min Zhao <zyimin(a)linux.ibm.com&gt; > > Add new functions to generate zPCI command string and append it to > QEMU command line. > > Signed-off-by: Yi Min Zhao <zyimin(a)linux.ibm.com&gt; > Reviewed-by: Boris Fiuczynski <fiuczy(a)linux.vnet.ibm.com&gt; > Reviewed-by: Stefan Zimmermann <stzi(a)linux.ibm.com&gt; > Reviewed-by: Bjoern Walk <bwalk(a)linux.vnet.ibm.com&gt; > --- > src/qemu/qemu_command.c | 104 > ++++++++++++++++++++++++++++++++++++++++++++++++ > src/qemu/qemu_command.h |   4 ++ > 2 files changed, 108 insertions(+) > > +static int > +qemuBuildExtensionCommandLine(virCommandPtr cmd, > +                              virQEMUCapsPtr qemuCaps, > +                              virDomainDeviceInfoPtr dev) > +{ > +    if (qemuCheckDeviceIsZPCI(dev)) { > +        if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_ZPCI)) { > +            virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", > +                           _("This QEMU doesn't support zpci > devices")); > +            return -1; > +        } Even though we have a lot of pre-existing code, qemuBuild* should not be reporting errors based on missing caps. That belongs in Validate. But it's not necessary here, because we would not have set VIR_PCI_ADDRESS_EXTENSION_ZPCI otherwise, right?

Jano > +        return qemuAppendZPCIDevStr(cmd, dev); > +    } > + > +    return 0; > +} > > static int > qemuBulildFloppyCommandLineOptions(virCommandPtr cmd,