On 02/09/2011 09:42 AM, Daniel P. Berrange wrote:
Most of te VIR_INFO calls in the udev driver are only relevant
s/te/the/
to developers so can switch to VIR_DEBUG. Failure to initialize
libpciaccess though is a fatal error
* src/node_device/node_device_udev.c: Adjust log levels
---
src/node_device/node_device_udev.c | 44 ++++++++++++++++++------------------
1 files changed, 22 insertions(+), 22 deletions(-)
@@ -1598,8 +1598,8 @@ static int udevDeviceMonitorStartup(int privileged
ATTRIBUTE_UNUSED)
if ((pciret = pci_system_init()) != 0) {
char ebuf[256];
- VIR_INFO("Failed to initialize libpciaccess: %s",
- virStrerror(pciret, ebuf, sizeof ebuf));
+ VIR_ERROR("Failed to initialize libpciaccess: %s",
+ virStrerror(pciret, ebuf, sizeof ebuf));
This won't pass 'make syntax-check'; you need _() for VIR_ERROR. ACK
with that nit fixed.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library
http://libvirt.org