2011/5/18 Taisuke Yamada <tai@rakugaki.org>:
Hi.
As reported by Diego Blanco in
- https://bugzilla.redhat.com/show_bug.cgi?id=702602
commit f0443765 which replaced openvz_readline to getline(3) broke OpenVZ driver as it changed semantics of EOF-handling when parsing OpenVZ configuration.
Ah yes, that's my fault :(
There're several other issues reported with current OpenVZ driver:
#1: unclear error message when parsing "CPUS=" line #2: openvz driver goes into crashing loop #3: "NETIF=" line in configuration is not parsed correctly #4: aborts even when optional parameter is missing #5: there's a potential memory leak
In this email, I'm sending in updated patch to fix #[145]. This patch does not fix #[23] as I haven't verified these yet, but this at least got me to run OpenVZ on libvirt once again.
I wrote a testcase [1] to verify that it worked before I broke it and that it works again after you fixed it. I've applied and pushed your patch. Thanks! [1] https://www.redhat.com/archives/libvir-list/2011-May/msg01716.html Matthias