Re: [libvirt] [PATCH] nwfilter: don't crash listing filters in unprivileged daemon

On 12/05/2017 11:41 AM, Daniel P. Berrange wrote: > The unprivileged libvirtd does not support nwfilter config, by leaves the > driver active. It is supposed to result in all APIs being an effective > no-op, but several APIs rely on driver->nwfilters being non-NULL, or they > will reference a NULL pointer. Rather than adding checks for NULL in many > places, just make sure driver->nwfilters is always initialized. > > Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com&gt; > --- > src/nwfilter/nwfilter_driver.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > I think nwfilterStateCleanup will also need a slight, but obvious adjustment... Reviewed-by: John Ferlan <jferlan(a)redhat.com&gt; John (and since it's in 3.9, I need a bz to handle a backport <sigh>)