On Tue, Dec 05, 2017 at 16:48:36 -0500, John Ferlan wrote:
On 12/05/2017 11:41 AM, Daniel P. Berrange wrote:
The unprivileged libvirtd does not support nwfilter config, by leaves the driver active. It is supposed to result in all APIs being an effective no-op, but several APIs rely on driver->nwfilters being non-NULL, or they will reference a NULL pointer. Rather than adding checks for NULL in many places, just make sure driver->nwfilters is always initialized.
Signed-off-by: Daniel P. Berrange <berrange@redhat.com> --- src/nwfilter/nwfilter_driver.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
I think nwfilterStateCleanup will also need a slight, but obvious adjustment...
Reviewed-by: John Ferlan <jferlan@redhat.com>
John
(and since it's in 3.9, I need a bz to handle a backport <sigh>)
You don't need BZs for backporting it to maintenance branches.