Re: [Libvir] [PATCH] Fix MAC address parsing for 1-digit case

Hiroyuki Kaguchi <fj7025cf(a)aa.jp.fujitsu.com&gt; wrote: > Thank you for your suggestions. > I apply the following changes to the patch. > 1) Initialize errno to 0 before the loop. > 2) Use isxdigit instead of isdigit and isalpha, and add a comment. > 3) Test errno != 0. > 4) Add a terminating NUL check. > 5) the MAC address function go in file src/util.c. Looks good. A couple nits. I didn't read the comments the first time.