On 24/06/16 16:06, Daniel P. Berrange wrote:
On Fri, Jun 24, 2016 at 03:59:38PM +0200, Michal Privoznik wrote:
On 24.06.2016 15:33, Daniel P. Berrange wrote:
On Fri, Jun 24, 2016 at 03:12:23PM +0200, Michal Privoznik wrote:
Currently, the daemon requires libvirt-admin.so because the functions encoding/decoding RPC messages for admin APIs live there. But this makes it very hard to split admin API into its own separate package: if libvirt-admin.so is going to live in a separate package than the daemon, either both packages must be installed or none. Solve this by statically linking the RPC message handling functions with the daemon.
I'm not sure I see any need for a separate package for libvirt-admin.so For libvirt-qemu.so and libvirt-lxc.so we keep them in libvirt-client RPM, and I'd expect libvirt-admin.so to be there too really.
So libvirt-client would contain not only virsh (and other .so files) but virt-admin binary too? Okay, if that's what we want my patch is useless. If we, however, want a separate package for libvirt-admin (which is kind of special compared to libvirt-qemu.so and libvirt-lxc.so), then I guess we need this patch.
Hmm, i guess libvirt-admin is only needed if libvirtd is actually present on the host. So I guess we could argue that virt-admin and libvirt-admin.so should just be a part of libvirt-daemon RPM.
Regards, Daniel
Well, yes, but although we currently only support local connections, it might not stay that way forever. I thought about supporting remote tunneled connection, in which case I think it would be better to place in the client package. Erik