Re: [libvirt] [PATCH] Move all the QEMU migration code to a new file

>> The functions are not moved 100%. The API entry points >> remain in the main QEMU driver, but once the public >> virDomainPtr is resolved to the internal virDomainObjPtr, >> all following code is moved. >> >> This will allow the new v3 API entry points to call into the >> same shared internal migration functions >> > The diffstat makes this look like a cleaner diff than the qemu_process > split, so it should be easier to review. > >> - qemu/qemu_process.c qemu/qemu_process.h \ >> + qemu/qemu_process.c qemu/qemu_process.h \ >> > However, this means that you depend on the qemu_process split to happen > first, and that one had issues, so I'm not reviewing this one yet (but I > do like the idea of the patch). The 2 line fix I posted to the other patch shouldn't invalidate this patch

+++ b/src/Makefile.am @@ -281,7 +281,8 @@ QEMU_DRIVER_SOURCES = \ qemu/qemu_hostdev.c qemu/qemu_hostdev.h \ qemu/qemu_hotplug.c qemu/qemu_hotplug.h \ qemu/qemu_conf.c qemu/qemu_conf.h \ - qemu/qemu_process.c qemu/qemu_process.h \ + qemu/qemu_process.c qemu/qemu_process.h \

+ qemu/qemu_migration.c qemu/qemu_migration.h \

+ + +char *qemuDomainFormatXML(struct qemud_driver *driver, + virDomainObjPtr vm, + int flags) +{

+ + if (!(cpu = virCPUDefCopy(def_cpu)) + || cpuUpdate(cpu, driver->caps->host.cpu))

-static char *qemudVMDumpXML(struct qemud_driver *driver, - virDomainObjPtr vm, - int flags) -{

- if (!(cpu = virCPUDefCopy(def_cpu)) - || cpuUpdate(cpu, driver->caps->host.cpu))