Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial
Cornelia Huck <cohuck(a)redhat.com> writes:
On Thu, 12 Jul 2018 08:51:16 +0200
Markus Armbruster <armbru(a)redhat.com> wrote:
> Markus Armbruster <armbru(a)redhat.com> writes:
>
> > Kevin Wolf <kwolf(a)redhat.com> writes:
> >
> >> I think the function should just take a message:
> >>
> >> /* Works like error_report(), except for the WARNING/ERROR prefix
> >> * and exit(1) if -no-deprecated-options is set */
> >> void deprecation_report(const char *fmt, ...);
> >
> > I like it. The contract could use a bit of polish, but that's detail.
>
> Suggest --deprecated={silent,warn,error}, default silent.
I like that, but I'd prefer to default to warn (so that command line
users have a better chance to notice it).
Fair enough.