21 Dec
2012
21 Dec
'12
2:44 p.m.
On 12/21/2012 05:40 AM, Laine Stump wrote:
On 12/20/2012 07:16 PM, Eric Blake wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=888426
The code for doing a block-copy was supposed to track the destination file in drive->mirror, but was set up to do all mallocs prior to starting the copy so that OOM wouldn't leave things partially started. However, the wrong variable was being written; later in the code we silently did 'disk->mirror = mirror' which was still NULL, and thus leaking memory and leaving libvirt to think that the mirror job was never started, which prevented a pivot operation after a copy.
ACK.
Thanks; pushed. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org