Re: [libvirt] [PATCH] blockjob: fix memleak that prevented block pivot

On 12/20/2012 07:16 PM, Eric Blake wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=888426 > > The code for doing a block-copy was supposed to track the destination > file in drive->mirror, but was set up to do all mallocs prior to > starting the copy so that OOM wouldn't leave things partially started. > However, the wrong variable was being written; later in the code we > silently did 'disk->mirror = mirror' which was still NULL, and thus > leaking memory and leaving libvirt to think that the mirror job was > never started, which prevented a pivot operation after a copy.

ACK.