Re: [Libvir] [PATCH] Another Report error in virsh.c code.
On Tue, Mar 11, 2008 at 07:19:57PM +0900, S.Sakamoto wrote:
I wish it is unified as follows.
***migrate***
2225 desturi = vshCommandOptString (cmd, "desturi", &found);
2226 if (!found) {
2227 vshError (ctl, FALSE, "%s", _("migrate: Missing
desturi"));
2228 goto done;
2229 }
***vcpupin***
1731 if (!(cpulist = vshCommandOptString(cmd, "cpulist", NULL))) {
+ vshError (ctl, FALSE, "%s", _("vcpupin: Missing
cpulist"));
1732 virDomainFree(dom);
1733 return FALSE;
1734 }
So the problem is just the text in the error message? ie. Instead
of:
$ virsh vcpupin
error: command 'vcpupin' requires <domain> option
error: command 'vcpupin' requires <vcpu> option
error: command 'vcpupin' requires <cpulist> option
you want it to print a different message, as in:
vcpupin: Missing cpulist
?
Rich.
--
Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones
virt-top is 'top' for virtual machines. Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://et.redhat.com/~rjones/virt-top