Re: [libvirt] [PATCH 1/3] virsh: Two new helper functions for disk device changes

vshFindDisk is to find the disk node in xml doc with given source path or target of disk device, and type (indicates disk type, normal disk or changeable disk). vshPrepareDiskXML is to make changes on the disk node (e.g. create and insert the new <source> node for inserting media of CDROM drive). They are marked as unused temporarily. --- tools/virsh.c | 215 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 215 insertions(+), 0 deletions(-)

+ if (STREQ_NULLABLE(device_type, "cdrom") || + STREQ_NULLABLE(device_type, "floppy")) { + bool has_source = false; + disk_type = virXMLPropString(disk_node, "type"); + + cur = disk_node->children; + while (cur != NULL) { + if (cur->type == XML_ELEMENT_NODE && + xmlStrEqual(cur->name, BAD_CAST "source")) { + has_source = true; + break; + } + cur = cur->next; + } + + if (!has_source) { + if (type == VSH_PREPARE_DISK_XML_EJECT) { + vshError(NULL, _("The disk device whose source path or target " + "is '%s' doesn't have media"), path);

+ + if (has_source) { + if (type == VSH_PREPARE_DISK_XML_INSERT) { + vshError(NULL, _("The disk device whose source path or target " + "is '%s' already has media"), path);