Re: [Libvir] [PATCH] Clean up the global name space.
Jim Meyering wrote:
After mentioning "avoid global variables" as a potential
addition to HACKING, I did some quick tests and spotted
a few that are easy to eliminate. This is useful even
if we don't end up automating the check:
Clean up the global name space.
* src/qemu_conf.c: Add "static" and "const" attributes to some
globals.
* src/qemu_conf.h: Update a declaration.
* src/qemu_driver.c (qemud_driver): Declare static.
+1.
These structures were originally shared between files, but lots of code
refactoring since seems to make that obsolete.
Rich.
--
Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in
England and Wales under Company Registration No. 03798903
Attachments:
- smime.p7s (application/x-pkcs7-signature — 3.2 KB)